Improve error messages when operations are not supported #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alamb Very practical PR! Some tests that relate to these error messages failed. BTW, I think using error messages in tests to judge maybe not be an elegant style. It is sufficient to test existing functionality.😁 What do you think? |
I think checking error messages in tests is very reasonable 👍 I will update the tests in a bit |
houqp
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1157
Rationale for this change
While working on #1153, i saw this kind of error:
Internal("Data type Boolean not supported for binary operation on dyn arrays")
But it took me a while to figure out what operation was wrong (in this case it was
eq)What changes are included in this PR?
Include the name of the operation in the error message
Are there any user-facing changes?
better error messages