make unparser Dialect trait Send + Sync
#11504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Thank you for this contribution @y-f-u
Another potential option is to pass around Arc<dyn Dialect + Send + Sync> instead of Arc<dyn Dialect> in your code.
However, that sounds annoying and unecessary and doesn't really follow the pattern of the rest of the DataFusion code.
I think it is fine to make this Send+Sync to make it easier for the Rust compiler to use this type in async closures.
I'll leave this PR open for a day in case any other maintainer wants to weigh in
alamb
changed the title
Dialect trait Send + Sync
|
🚀 |
|
Thanks again @y-f-u |
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Jul 23, 2024
wiedld
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This makes unparser trait
Dialecteasier to work within DataFusion context for federated queries (datafusion-federation).Rationale for this change
In federated query context, that could be use cases that a dialect needs to be specified for table providers targeting protocol like flight, odbc because the underlying DBMS may have different sql dialect. Without Send + Sync, it can be tricky to pass the config of dialect down into table provider scan/execute method, etc.
In current design, the dialect is mostly an empty struct so it's safe to change so. The alternative is to pass a
fnwhich create aArc<dyn Dialect>around which doesn't look great.Thoughts?
What changes are included in this PR?
Make Unparser Dialect to be Send + Sync
Are these changes tested?
n/a. I don't think it needs one.
Are there any user-facing changes?
n/a