Make running in docker instruction be copy-pastable #11148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following renames after the project extracted from Arrow.
findepi
commented
Jun 27, 2024
| @@ -57,6 +57,8 @@ this to work. | |||
| ```bash | |||
There was a problem hiding this comment.
btw i was confused by the note about having to delete the .dockerignore file.
do you maybe know when this can be needed?
There was a problem hiding this comment.
I do not know what that documentation refers to
There was a problem hiding this comment.
i mean the line above
Note that there is
.dockerignorefile in the root of the repository that may need to be deleted in order for this to work.
There was a problem hiding this comment.
Sorry - I meant that I didn't know when it was needed or if it was still needed
alamb
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Looks great to me -- thank you @findepi
I tested it out locally and it works great
andrewlamb@Andrews-MacBook-Pro-2:/tmp/datafusion$ docker run --rm -it datafusion-cli
DataFusion CLI v39.0.0
>
\q
cc @Omega359 and @andygrove
|
Thanks again @findepi |
comphead
pushed a commit
to comphead/arrow-datafusion
that referenced
this pull request
Jul 2, 2024
* Migrate arrow-datafusion paths in Dockerfile Following renames after the project extracted from Arrow. * Make running in docker instruction be copy-pastable
findepi
added a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Migrate arrow-datafusion paths in Dockerfile Following renames after the project extracted from Arrow. * Make running in docker instruction be copy-pastable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.