Add standalone AnalyzerRule example that implements row level access control
#11089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/analyzer_rule
branch
from
3ef7b8e to
78d271f
Compare
alamb
changed the title
goldmedal
approved these changes
Jun 25, 2024
| // | Andrew | 22 | Manager | | ||
| // | Chunchun | 44 | Manager | | ||
| // +----------+-----+----------+ | ||
| rule.set_show_position("Manager"); |
There was a problem hiding this comment.
Gave me a lot of inspiration. It's exactly what a semantic engine will do.
alamb
changed the title
alamb
changed the title
AnalyzerRule example that implements row level access control
|
Thank you for the review @jonahgao and @goldmedal |
comphead
pushed a commit
to comphead/arrow-datafusion
that referenced
this pull request
Jul 8, 2024
…s control (apache#11089) * Add standlone example AnalyzerRule * Apply suggestions from code review Co-authored-by: Jax Liu <[email protected]> * update for api change * Apply suggestions from code review Co-authored-by: Jonah Gao <[email protected]> --------- Co-authored-by: Jax Liu <[email protected]> Co-authored-by: Jonah Gao <[email protected]>
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…s control (apache#11089) * Add standlone example AnalyzerRule * Apply suggestions from code review Co-authored-by: Jax Liu <[email protected]> * update for api change * Apply suggestions from code review Co-authored-by: Jonah Gao <[email protected]> --------- Co-authored-by: Jax Liu <[email protected]> Co-authored-by: Jonah Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10855
Rationale for this change
It is common to use DataFusion to analyze / modify queries, so it would be good to have some more full featured examples of doing so.
Additionally, the current
rewrite_expr.rsexample has three distinct examples:AnalyzerRuleOptimizerRuleEach I think should be its own example to make them easier to find and more full featured
What changes are included in this PR?
analyzer_rule.rsthat implements "row level access control". I was inspired by @goldmedal 's description of Wren's usecase in Add example for writing anAnalyzerRule#10855 (comment) to pick the row level access control exampleAre these changes tested?
By CI
Are there any user-facing changes?