Clean up spawned task on SortStream drop
#1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Oct 11, 2021
There was a problem hiding this comment.
I think this is a great change. The code looks good and the pattern for code and testing makes sense to me
Thanks @crepererum !
|
cc @Dandandan @houqp |
crepererum
force-pushed
the
crepererum/issue1103a
branch
from
1de1108 to
7be24fb
Compare
houqp
approved these changes
Oct 12, 2021
This was referenced Oct 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only the first part for #1103.
I just want to check that the approach is OK. I think the testing infrastructure designed here (
BlockingExecandBlockingStream) can later easily be reused. I you agree I would move it todatafusion::test::execand add a bit more documentation.The
pin-project-liteupdate is required forPinnedDrop.