Support negatives in split part #10780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jun 3, 2024
| let len = split_string.len(); | ||
|
|
||
| let index = match n.cmp(&0) { | ||
| std::cmp::Ordering::Less => len as i64 + n, |
There was a problem hiding this comment.
so negative parts mean "index from end" rather than index from beginning? Makes sense to me.
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* impv: support negative indexes for split_part * tests: update unittests in func * tests: add out of bounds negative test * style: fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10761
Rationale for this change
Postgres at least supports negative index in split_part. It'd be nice to for datafusion to similarly, since
split_part(..., ..., -1)is not unheard of.What changes are included in this PR?
Updated code and tests.
Are these changes tested?
Yes, added new sqllogictests and updated exists unittests.
Are there any user-facing changes?
User queries which may've failed no longer will.