Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: (Doc) Enable rt-multi-thread feature for sample code #10770

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

hsiang-c
Copy link
Contributor

@hsiang-c hsiang-c commented Jun 3, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

  • The sample code in docs/source/user-guide/example-usage.md is not working with tokio = "1.0" dependency. The error I got is
error: The default runtime flavor is `multi_thread`, but the `rt-multi-thread` feature is disabled.
 --> src/main.rs:3:1
  |
3 | #[tokio::main]
  | ^^^^^^^^^^^^^^
  |
  = note: this error originates in the attribute macro `tokio::main` (in Nightly builds, run with -Z macro-backtrace for more info)

What changes are included in this PR?

  • Enabled rt-multi-thread feature in tokio.

Are these changes tested?

Yes. I got the expected output

+---+----------------+
| a | MIN(example.b) |
+---+----------------+
| 1 | 2              |
+---+----------------+

Are there any user-facing changes?

Nope

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you @hsiang-c 🙏 -- very nice

@alamb alamb merged commit ccf395f into apache:main Jun 3, 2024
4 checks passed
@alamb alamb added the documentation Improvements or additions to documentation label Jun 3, 2024
@hsiang-c
Copy link
Contributor Author

hsiang-c commented Jun 3, 2024

Thank you @alamb

@hsiang-c hsiang-c deleted the doc_deps_fix branch June 3, 2024 23:22
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants