minor: consolidate unparser integration tests #10736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinjdangelo
changed the title
alamb
approved these changes
May 31, 2024
There was a problem hiding this comment.
Looks good to me -- thank you @devinjdangelo
What would you think about using the same test binary (rather than making a new one, which is like 100MB or something last I checked)?
To do so, I think we could do something like
- move
datafusion/sql/tests/plan_to_sql.rstodatafusion/sql/tests/cases/plan_to_sql.rs - Add
mod casestodatafusion/sql/tests/sql_integration.rs
We could do it as a follow on PR (or never) too
alamb
approved these changes
Jun 1, 2024
There was a problem hiding this comment.
I ran the test manually just to make sure the tests are running and they are! Thanks again @devinjdangelo
(venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion2$ cargo test --test sql_integration
...
test cases::plan_to_sql::roundtrip_statement ... ok
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* consolidate unparser integration tests * add license to new files * surpress dead code warnings * run as one integration test binary * add license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10635
Rationale for this change
Moving plan to sql related integration tests to a dedicated integration test mod.
What changes are included in this PR?
datafusion/sql/tests/plan_to_sql.rsdatafusion/sql/tests/common/mod.rsand moved common utilities thereAre these changes tested?
Just reorganizing existing tests.
Are there any user-facing changes?
No