Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix complaints from newer Clippy versions #10725

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

comphead
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label May 30, 2024
@comphead comphead changed the title CI: Fix compaints from newer Clippy versions CI: Fix complaints from newer Clippy versions May 30, 2024
@comphead comphead requested review from houqp and alamb May 30, 2024 16:13
Copy link

@parthchandra parthchandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @comphead

@alamb alamb merged commit 904f0db into apache:main May 30, 2024
24 checks passed
@alamb
Copy link
Contributor

alamb commented May 30, 2024

Thank you!

@viirya
Copy link
Member

viirya commented May 30, 2024

Isn't this already fixed by #10723? 😄

@alamb
Copy link
Contributor

alamb commented May 30, 2024

Double fix 🤔 well it should be really fixed now 😆

Update: @viirya is right (the squashed commit from this PR is empty: 904f0db)

findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants