Fix NULL["field"] for expr_API
#10655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
NULL["field"] for expr_API
jayzhan211
reviewed
May 25, 2024
| @@ -106,6 +106,9 @@ impl ScalarUDFImpl for GetFieldFunc { | |||
| }; | |||
| let access_schema = GetFieldAccessSchema::NamedStructField { name: name.clone() }; | |||
| let arg_dt = args[0].get_type(schema)?; | |||
| if arg_dt.is_null() { | |||
| return Ok(DataType::Null); | |||
| } | |||
| access_schema | |||
There was a problem hiding this comment.
I quickly fixed it before noticing that there was already a PR
I think we can remove GetFieldAccessSchema, get_accessed_field. 6cb45b5
There was a problem hiding this comment.
Thanks @jayzhan211
I agree the change in 6cb45b5 to inline things looks nice -- shall we make another PR?
jayzhan211
approved these changes
May 25, 2024
|
Thank you for the speedy review @jayzhan211 |
jayzhan211
pushed a commit
to jayzhan211/datafusion
that referenced
this pull request
May 26, 2024
appletreeisyellow
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
May 28, 2024
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10654
Rationale for this change
This used to work (and we used it in IOx when we were programatically creating expressions):
Now it returns an error:
What changes are included in this PR?
Support
NULL["field"Are these changes tested?
Yes, new unit tests are added
Are there any user-facing changes?
Fix regression