Factor out common datafusion types into another proto file #10649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozankabak
approved these changes
May 24, 2024
There was a problem hiding this comment.
This looks good to me. Even though this PR is merely and organizational change, it moves a non-trivial amount of code around, so it'd be good to get a careful review from at least one more person. @alamb or @andygrove, do you have time to take a look?
@comphead and @jayzhan211 it'd be good if you took a look too. Let's make sure not to miss anything
comphead
reviewed
May 24, 2024
comphead
reviewed
May 24, 2024
comphead
reviewed
May 24, 2024
| use datafusion_common::DataFusionError; | ||
|
|
||
| pub fn proto_error<S: Into<String>>(message: S) -> DataFusionError { | ||
| DataFusionError::Internal(message.into()) |
comphead
reviewed
May 24, 2024
comphead
approved these changes
May 24, 2024
There was a problem hiding this comment.
This PR is 💪
Thanks @mustafasrepo
I left some minor comments which doesn't block the PR
alamb
approved these changes
May 24, 2024
There was a problem hiding this comment.
LGTM too -- thanks @mustafasrepo
cc @andygrove as we'll have to release the new crate as part of the next release
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
) * Initial commit * Minor changes * Minor changes * Minor changes * Minor changes * Move Column type * Minor changes buggy * Compiles * Add new types to common * Move scalarvalue * Move new types to common * Move additional fields * Move common types * Minor changes * Change proto definition order * Simplifications * Minor changes * REimport protobuf_common from proto * Address reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10477.
Rationale for this change
See issue body for the motivation.
This PR moves protobuf serialialization, deserialization codes for the common types in the Datafusion (e.g types that are under
datafusion_common) into another proto crate nameddatafusion_proto_common(where its only dependency from datafusion isdatafusion_common).Note: This PR, is just reorganization of the existing code.
What changes are included in this PR?
Are these changes tested?
Existing tests should work
Are there any user-facing changes?