UDAF: Extend more args to state_fields and groups_accumulator_supported and introduce ReversedUDAF
#10525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Signed-off-by: jayzhan211 <[email protected]>
alamb
reviewed
May 15, 2024
There was a problem hiding this comment.
Thanks @jayzhan211 -- I think this is a very nice PR 🙏
The only thing I think we should consider is reusing AccumulatorArgs rather than adding GroupsAccumulatorSupportedArgs
| sort_exprs, | ||
| } | ||
| } | ||
| pub struct StateFieldsArgs<'a> { |
There was a problem hiding this comment.
Can we please add doc comments to this explaining what it is for?
datafusion/expr/src/function.rs
Outdated
|
|
||
| /// [`GroupsAccumulatorSupportedArgs`] contains information to determine if an | ||
| /// aggregate function supports the groups accumulator. | ||
| pub struct GroupsAccumulatorSupportedArgs { |
There was a problem hiding this comment.
I know the current implementation of groups_accumulator_supported only needs these two fields, but I can see in the future needing more of them
Is there any reason we can't just pass AccumulatorArgs to groups_accumulator_supported?
There was a problem hiding this comment.
We could do this.
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…orted` and introduce `ReversedUDAF` (apache#10525) * extends args Signed-off-by: jayzhan211 <[email protected]> * reuse accumulator args Signed-off-by: jayzhan211 <[email protected]> * fix example Signed-off-by: jayzhan211 <[email protected]> --------- Signed-off-by: jayzhan211 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10391.
Rationale for this change
This PR is pulled from #10484 and it has a similar rationale in #10391 but the changes in this PR are for #10484
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?