Minor: add a test for current_time (no args)
#10509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
May 14, 2024
|
|
||
| # Test current_time without parentheses | ||
| query B | ||
| select current_time = current_time; |
There was a problem hiding this comment.
it is somewhat 🤯 that current_time doesn't require ()
4 tasks
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
While working with @tisonkun on #10392 I realized there was no test coverage for the
current_timeform (with no parens). I added a test and a fix to that branch but I want to make sure we don't accidentally break it before that PR landsWhat changes are included in this PR?
current_timesyntaxAre these changes tested?
All tests
Are there any user-facing changes?