DRAFT: example fix to make stride optional in array_slice UDF
#10450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All i did was expand the `make_udf_function` macro and add the `if let Some(stride) = stride` conditional. To me, making the argument `Option<_>` is the natural way to make it optional in rust. I don't know if this solution violates other datafusion constraints, but `cargo test` all passed. Ref: apache#10424
|
Closing in favor of #10469 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All i did was expand the
make_udf_functionmacro and add theif let Some(stride) = strideconditional.To me, making the argument
Option<_>is the natural way to make it optional in rust.I don't know if this solution violates other datafusion constraints, but
cargo testall passed.Ref: #10424