Stop copying LogicalPlan and Exprs in PropagateEmptyRelation
#10332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demetribu
force-pushed
the
10290-optimise-propagate-empty-relation
branch
from
5b6a4fc to
95eb2d6
Compare
demetribu
force-pushed
the
10290-optimise-propagate-empty-relation
branch
from
95eb2d6 to
2edfff4
Compare
alamb
changed the title
PropagateEmptyRelation
alamb
approved these changes
May 2, 2024
There was a problem hiding this comment.
Thank you @dmitrybugakov -- this looks very nice. I took a look at empty_child
Thanks again -- really nice to see these contributions
| @@ -290,6 +291,32 @@ fn eliminate_nested_filters() { | |||
| assert_eq!(expected, format!("{plan:?}")); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_propagate_empty_relation_inner_join_and_unions() { | |||
There was a problem hiding this comment.
❤️ for the additional coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10290.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?