Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with missing use ( " return internal_err!("UDF returned a different ...") #10317

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Apr 30, 2024

Which issue does this PR close?

It appears #10277 had a logical conflict

https://github.com/apache/datafusion/actions/runs/8899641374/job/24439454308

error: cannot find macro `internal_err` in this scope
   --> datafusion/physical-expr/src/scalar_function.rs:156:32
    |
156 |                         return internal_err!("UDF returned a different number of rows than expected. Expected: {}, Got: {}", 
    |                                ^^^^^^^^^^^^
    |
help: consider importing this macro
    |
32  + use datafusion_common::internal_err;

Rationale for this change

Fix build

What changes are included in this PR?

Add required use

Are these changes tested?

CI

Are there any user-facing changes?

@alamb alamb changed the title Fix build with missing use Fix build with missing use ( " return internal_err!("UDF returned a different ...") Apr 30, 2024
@alamb alamb requested review from comphead and andygrove April 30, 2024 18:37
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch @alamb

@alamb alamb merged commit a5657e1 into apache:main Apr 30, 2024
24 of 25 checks passed
@alamb
Copy link
Contributor Author

alamb commented Apr 30, 2024

Thanks @comphead

@alamb alamb deleted the alamb/fix_build branch April 30, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants