Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Prevent empty datafusion-cli commands #10219

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Minor: Prevent empty datafusion-cli commands #10219

merged 3 commits into from
Apr 25, 2024

Conversation

comphead
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Prevent empty datafusion-cli commands

datafusion-cli --command ""
datafusion-cli -c ""
datafusion-cli --command "" "command"
datafusion-cli -c "" "command"

What changes are included in this PR?

Are these changes tested?

Yes, manually

Are there any user-facing changes?

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also double checked it

     Running `target/debug/datafusion-cli -c ''`
error: Invalid value "" for '--command <COMMAND>...': -c flag expects only non empty commands

👍 - thanks @comphead

@alamb alamb merged commit b9f17b0 into apache:main Apr 25, 2024
23 checks passed
ccciudatu pushed a commit to hstack/arrow-datafusion that referenced this pull request Apr 26, 2024
* Prevent empty datafusion-cli commands

* err msg

* clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants