-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .asf.yaml to publish docs to datafusion.apache.org #10190
Update .asf.yaml to publish docs to datafusion.apache.org #10190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @phillipleblanc. I think it would be good to wait for @alamb to also review before merging.
Yeah - there are some links to arrow.apache.org/datafusion still leftover in the repo as well - but I also think we should wait on those changes until we confirm this actually publishes to the right place. Also I wasn't able to figure out how to add the redirect from arrow.apache.org/datafusion to datafusion.apache.org. @alamb did you have an idea on how to do that? |
@@ -27,7 +27,7 @@ notifications: | |||
jira_options: link label worklog | |||
github: | |||
description: "Apache DataFusion SQL Query Engine" | |||
homepage: https://arrow.apache.org/datafusion | |||
homepage: https://datafusion.apache.org/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be https://datafusion.apache.org/datafusion/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this change it should start publishing to https://datafusion.apache.org without needing the subdirectory 🤞
The only thing I could think of is creating explicit redirect pages for each .html page in https://github.com/apache/arrow-site I agree having redirects will be important (and I m am not sure what will be on https://arrow.apache.org/datafusion/ afterwards). Thus what I think we should do is to merge this PR, see its effects and I'll file a follow on ticket for the next tasks |
Thank you for your work / help and reviews @phillipleblanc |
Filed #10194 to track redirects |
It appears to have worked! https://datafusion.apache.org/ now shows: |
It appears that https://arrow.apache.org/datafusion/ has an older snapshot of the site (as in it was not updated as well): |
I think I have figured out the redirects -- see apache/arrow-site#502 |
* Update .asf.yaml to publish to root * Update website to have top-level ASF links
Which issue does this PR close?
Closes #10151
Rationale for this change
What changes are included in this PR?
Updates
.asf.yaml
to point to the new top-level website, and adds the required links to the ASF as required by https://www.apache.org/foundation/marks/pmcs#navigationI mirrored what https://arrow.apache.org does and grouped these links into an
ASF Links
sectionAccording to https://github.com/apache/infrastructure-asfyaml/blob/main/README.md#publish - removing the
subdir
config inpublish
will do what we want.Are these changes tested?
Here is a screenshot of what it looks like locally:
![Screenshot 2024-04-23 at 11 40 35 AM](https://private-user-images.githubusercontent.com/879445/324668871-15bab8b2-c747-494b-801a-96265f1279f2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4OTg2NDMsIm5iZiI6MTczODg5ODM0MywicGF0aCI6Ii84Nzk0NDUvMzI0NjY4ODcxLTE1YmFiOGIyLWM3NDctNDk0Yi04MDFhLTk2MjY1ZjEyNzlmMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QwMzE5MDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mNWI5YTY5NzM0ODE3ZmU4OGNhOThiYzVmNzgxMDdlYTdkMDllYTI2MjNjM2Q2M2IxYjAxZGNmOGJlMzMyYTk2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.wdIasr5EHMaRVBrVlPwOcm3Xkmn6MP7J87iyf_P6oGs)
Are there any user-facing changes?
N/A