cleanup(tests): Move tests from push_down_projections.rs to optimize_projections.rs
#10071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @kavirajk 🙏 ! |
…ze_projections.rs` Fixes: apache#9978 The PR apache#8340 removed `push_down_projections.rs` in favour of `optimize_projections.rs`. This PR moves the tests as well. Signed-off-by: Kaviraj <[email protected]>
Signed-off-by: Kaviraj <[email protected]>
Signed-off-by: Kaviraj <[email protected]>
kavirajk
force-pushed
the
kavirajk/migrate-push-down-projection-tests
branch
from
50c449d to
ba36340
Compare
Signed-off-by: Kaviraj <[email protected]>
alamb
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Thank you @kavirajk -- this is a very nice first contribution. 🧹 ✅
FYI @mustafasrepo and @jackwener
mustafasrepo
approved these changes
Apr 15, 2024
|
Thanks again @kavirajk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9978
Rationale for this change
The PR #8340 removed
push_down_projections.rsin favour ofoptimize_projections.rs. This PR moves the tests as well.What changes are included in this PR?
Moving tests. No other changes.
Are these changes tested?
Yes
Are there any user-facing changes?
No