Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always pass DataType to PrimitiveDistinctCountAccumulator #10047

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Always pass DataType to PrimitiveDistinctCountAccumulator #10047

merged 1 commit into from
Apr 11, 2024

Conversation

joroKr21
Copy link
Contributor

@joroKr21 joroKr21 commented Apr 11, 2024 •
edited
Loading

Which issue does this PR close?

Followup to #10043

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

alamb
alamb approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @joroKr21 -- I think this is a good improvement and will be less likely to lead to subtle bugs

@Dandandan Dandandan merged commit 118eecd into apache:main Apr 11, 2024
24 of 25 checks passed
@Dandandan Dandandan deleted the cleanup/distinct-count branch April 11, 2024 19:41
@Dandandan
Copy link
Contributor

Nice, thanks @joroKr21 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@Dandandan Dandandan Dandandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joroKr21 @Dandandan @alamb