Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncPutWriter::poll_shutdown_inner Incorrect #7991

Closed
tustvold opened this issue Oct 30, 2023 · 0 comments · Fixed by #8017
Closed

AsyncPutWriter::poll_shutdown_inner Incorrect #7991

tustvold opened this issue Oct 30, 2023 · 0 comments · Fixed by #8017
Assignees
Labels
bug Something isn't working

Comments

@tustvold
Copy link
Contributor

tustvold commented Oct 30, 2023

Describe the bug

AsyncPutWriter has the following code

AsyncPutState::Put { bytes } => {
    // Send the bytes to the object store's put method
    return Poll::Ready(
        ready!(self
            .store
            .put(&self.object_meta.location, bytes.clone())
            .poll_unpin(cx))
        .map_err(Error::from),
    );
}

This will only work if store.put doesn't return Poll::Pending, in such a case the future will get dropped, cancelling the operation and never rescheduling the waker.

FYI @devinjdangelo

To Reproduce

No response

Expected behavior

No response

Additional context

No response

@tustvold tustvold added the bug Something isn't working label Oct 30, 2023
@tustvold tustvold self-assigned this Oct 30, 2023
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant