Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review existing datafusion benchmarks and clean them up #5502

Closed
alamb opened this issue Mar 7, 2023 · 1 comment
Closed

Review existing datafusion benchmarks and clean them up #5502

alamb opened this issue Mar 7, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Mar 7, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

There are several datafusion specific existing benchmarks (taxi, etc) https://github.com/apache/arrow-datafusion/tree/main/benchmarks

It is not clear if these benchmarks are run / actively used . It would be nice to pick one or two to run regularly and remove the code for the rest

Describe the solution you'd like
I would like someone to review the benchmarks and remove the unused ones

I propose:

  1. Remove nytaxi benchmark
  2. remove dbbenchmark https://github.com/apache/arrow-datafusion/blob/main/benchmarks/db-benchmark as that benchmark seems defunct

Describe alternatives you've considered
Leave current situation

Additional context

@alamb alamb added the enhancement New feature or request label Mar 7, 2023
alamb added a commit that referenced this issue Mar 7, 2023
I was researching benchmarks as part of #5502 and I had to do some digging to figure out what dbenchmark was
alamb added a commit that referenced this issue Mar 9, 2023
I was researching benchmarks as part of #5502 and I had to do some digging to figure out what dbenchmark was
@alamb alamb changed the title Review existing benchmarks / clean up Review existing datafusion benchmarks and clean them up Apr 28, 2023
@alamb alamb self-assigned this May 8, 2023
@alamb
Copy link
Contributor Author

alamb commented Sep 11, 2023

I think this is now complete

@alamb alamb closed this as completed Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant