You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Now that DF emits ResourceExhausted errors for out-of-memory situations, it would be nice if the API user could somehow detect this situation (e.g. to convert this to a suitable HTTP status code).
Describe the solution you'd like
There are a few places where we convert errors to strings, mostly to wrap them into DataFusionError::Execution(...). However DF (and Arrow) have ways to wrap arbitrary error types (external error). To send errors to multiple receivers, they can easily be wrapped into Arcs (Arc forwards std::error::Error).
Describe alternatives you've considered
Perform string "parsing" on the top-level err.to_string(). This is pretty bad code smell.
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Now that DF emits
ResourceExhausted
errors for out-of-memory situations, it would be nice if the API user could somehow detect this situation (e.g. to convert this to a suitable HTTP status code).Describe the solution you'd like
There are a few places where we convert errors to strings, mostly to wrap them into
DataFusionError::Execution(...)
. However DF (and Arrow) have ways to wrap arbitrary error types (external error). To send errors to multiple receivers, they can easily be wrapped intoArc
s (Arc
forwardsstd::error::Error
).Describe alternatives you've considered
Perform string "parsing" on the top-level
err.to_string()
. This is pretty bad code smell.Additional context
See #3940 for an application.
The text was updated successfully, but these errors were encountered: