-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execute LogicalPlans after building for TPCH Benchmarks #3273
Comments
This is happening because of the way tpch is running the test queries. q15 is made up of 3 SQL statements. run_query() attempts to create a plan for each of them before executing them. The second statement in q15 references the revenue0 view created in the first statement (which isn't created yet), so the planning of the second statement fails. Probably run_query() should be modified to execute the statements in turn, rather than attempting to plan all of them before beginning execution. |
That's exactly what I was thinking looking at it last night, and I was just writing a test to confirm by splitting the query. @kmitchener good to know I'm moving in the right direction. Assuming I get a different error by splitting the query, I'll try and rewrite the testing process in tpch.rs and see if it fixes this problem. |
This ☝️ . AFAIK, the TPC-H queries are what they are, and we have to run them as such. This one is ensuring we support multiple queries in one command, so to be TPC-H compliant I think it has to "just work". |
- tpch.rs::benchmark_datafusion now executes LogicalPlan immediately after building - tpch.rs::run_query now executes LogicalPlan immediately after building Resolves apache#3273
Describe the bug
Currently, running Q15 fails when attempting to build the second (SELECT) portion of the overall query.
The error is similar to the following:
To Reproduce
Run test run_q15 in
benchmarks/src/bin/tpch.rs
Expected behavior
I expect the test to fail due to either #3266 or #3267
Additional context
The table names just before failure are:
I'm unsure of where views populate this table, if anyone else has knowledge here that would be great.
The text was updated successfully, but these errors were encountered: