minor: improve error style (#5510)

apache · Mar 8, 2023 · ff013e2 · ff013e2
1 parent e46924d
commit ff013e2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/datafusion/core/tests/simplification.rs b/datafusion/core/tests/simplification.rs
@@ -51,10 +51,7 @@ impl SimplifyInfo for MyInfo {
     }
 
     fn get_data_type(&self, expr: &Expr) -> Result<DataType> {
-        match expr.get_type(&self.schema) {
-            Ok(expr_data_type) => Ok(expr_data_type),
-            Err(e) => Err(e),
-        }
+        expr.get_type(&self.schema)
     }
 }
 

diff --git a/datafusion/optimizer/src/simplify_expressions/context.rs b/datafusion/optimizer/src/simplify_expressions/context.rs
@@ -129,10 +129,7 @@ impl<'a> SimplifyInfo for SimplifyContext<'a> {
     /// Returns data type of this expr needed for determining optimized int type of a value
     fn get_data_type(&self, expr: &Expr) -> Result<DataType> {
         if self.schemas.len() == 1 {
-            match expr.get_type(&self.schemas[0]) {
-                Ok(expr_data_type) => Ok(expr_data_type),
-                Err(e) => Err(e),
-            }
+            expr.get_type(&self.schemas[0])
         } else {
             Err(DataFusionError::Internal(
                 "The expr has more than one schema, could not determine data type"