Implementing feedback from PR

apache · Jul 30, 2024 · eb0ebe0 · eb0ebe0
1 parent 1f49529
commit eb0ebe0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/datafusion/expr/src/udaf.rs b/datafusion/expr/src/udaf.rs
@@ -254,8 +254,8 @@ impl AggregateUDF {
     /// None in all other cases, used in certain optimizations or
     /// or aggregate
     ///
-    pub fn get_minmax_desc(&self) -> Option<bool> {
-        self.inner.get_minmax_desc()
+    pub fn is_descending(&self) -> Option<bool> {
+        self.inner.is_descending()
     }
 }
 
@@ -551,7 +551,7 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
     ///
     ///
     /// Note: this is used to use special aggregate implementations in certain conditions
-    fn get_minmax_desc(&self) -> Option<bool> {
+    fn is_descending(&self) -> Option<bool> {
         None
     }
 }

diff --git a/datafusion/physical-expr-common/src/aggregate/mod.rs b/datafusion/physical-expr-common/src/aggregate/mod.rs
@@ -733,7 +733,7 @@ impl AggregateExpr for AggregateFunctionExpr {
 
     fn get_minmax_desc(&self) -> Option<(Field, bool)> {
         self.fun
-            .get_minmax_desc()
+            .is_descending()
             .and_then(|flag| self.field().ok().map(|f| (f, flag)))
     }
 }