Skip to content

Commit

Permalink
fix comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
Rachelint committed Nov 4, 2024
1 parent e4bd579 commit e0635fe
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions datafusion/physical-plan/src/aggregates/group_values/column.rs
Original file line number Diff line number Diff line change
Expand Up @@ -207,9 +207,8 @@ impl<const STREAMING: bool> GroupValuesColumn<STREAMING> {

/// Scalarized intern
///
/// This is used only for `streaming aggregation`,
/// because it depends on the order between `input rows` and their corresponding
/// `group indices`.
/// This is used only for `streaming aggregation`, because `streaming aggregation`
/// depends on the order between `input rows` and their corresponding `group indices`.
///
/// For example, assuming `input rows` in `cols` with 4 new rows
/// (not equal to `exist rows` in `group_values`, and need to create
Expand All @@ -222,7 +221,7 @@ impl<const STREAMING: bool> GroupValuesColumn<STREAMING> {
/// row4
/// ```
///
/// # In [`GroupValuesColumn`], their `group indices` will be
/// # In `scalarized_intern`, their `group indices` will be
///
/// ```text
/// row1 --> 0
Expand All @@ -234,7 +233,7 @@ impl<const STREAMING: bool> GroupValuesColumn<STREAMING> {
/// `Group indices` order agrees with their input order, and the `streaming aggregation`
/// depends on this.
///
/// # However In [`VectorizedGroupValuesColumn`], their `group indices` will be
/// # However In `vectorized_intern`, their `group indices` will be
///
/// ```text
/// row1 --> 2
Expand Down Expand Up @@ -1020,7 +1019,7 @@ impl<const STREAMING: bool> GroupValues for GroupValuesColumn<STREAMING> {
self.hashes_buffer.clear();
self.hashes_buffer.shrink_to(count);

// Such structure is only used in `non-streaming` case
// Such structures are only used in `non-streaming` case
if !STREAMING {
self.group_index_lists.clear();
self.emit_group_index_list_buffer.clear();
Expand Down

0 comments on commit e0635fe

Please sign in to comment.