Skip to content

Commit

Permalink
Add line that prevents display_name from being called on Wildcard (#4682
Browse files Browse the repository at this point in the history
)

* Add line that prevents display_name from being called on Wildcard

* Move wildcard line to create_name()
  • Loading branch information
andre-cc-natzka authored Dec 21, 2022
1 parent ac2e5d1 commit bfef105
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions datafusion/expr/src/expr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1355,9 +1355,7 @@ fn create_name(e: &Expr) -> Result<String> {
Expr::Sort { .. } => Err(DataFusionError::Internal(
"Create name does not support sort expression".to_string(),
)),
Expr::Wildcard => Err(DataFusionError::Internal(
"Create name does not support wildcard".to_string(),
)),
Expr::Wildcard => Ok("*".to_string()),
Expr::QualifiedWildcard { .. } => Err(DataFusionError::Internal(
"Create name does not support qualified wildcard".to_string(),
)),
Expand Down

0 comments on commit bfef105

Please sign in to comment.