minor support mod operation for expr (#1467)

apache · Dec 20, 2021 · b5082e0 · b5082e0
1 parent 07b2985
commit b5082e0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/ballista/rust/core/src/serde/mod.rs b/ballista/rust/core/src/serde/mod.rs
@@ -97,6 +97,7 @@ pub(crate) fn from_proto_binary_op(op: &str) -> Result<Operator, BallistaError>
         "Minus" => Ok(Operator::Minus),
         "Multiply" => Ok(Operator::Multiply),
         "Divide" => Ok(Operator::Divide),
+        "Modulo" => Ok(Operator::Modulo),
         "Like" => Ok(Operator::Like),
         "NotLike" => Ok(Operator::NotLike),
         other => Err(proto_error(format!(

diff --git a/datafusion/src/logical_plan/operators.rs b/datafusion/src/logical_plan/operators.rs
@@ -127,6 +127,14 @@ impl ops::Div for Expr {
     }
 }
 
+impl ops::Rem for Expr {
+    type Output = Self;
+
+    fn rem(self, rhs: Self) -> Self {
+        binary_expr(self, Operator::Modulo, rhs)
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use crate::prelude::lit;
@@ -149,5 +157,9 @@ mod tests {
             format!("{:?}", lit(1u32) / lit(2u32)),
             "UInt32(1) / UInt32(2)"
         );
+        assert_eq!(
+            format!("{:?}", lit(1u32) % lit(2u32)),
+            "UInt32(1) % UInt32(2)"
+        );
     }
 }