Fix code generation for json feature (#3367)

apache · Sep 5, 2022 · 827cab9 · 827cab9
1 parent ede82fb
commit 827cab9
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/datafusion/proto/build.rs b/datafusion/proto/build.rs
@@ -55,7 +55,7 @@ fn build() -> Result<(), String> {
     let mut file = std::fs::OpenOptions::new()
         .write(true)
         .create(true)
-        .open("src/generated/datafusion.rs")
+        .open("src/generated/datafusion_json.rs")
         .unwrap();
     file.write(proto.as_str().as_ref()).unwrap();
     file.write(json.as_str().as_ref()).unwrap();

diff --git a/datafusion/proto/src/generated/mod.rs b/datafusion/proto/src/generated/mod.rs
@@ -18,4 +18,10 @@
 // include the generated protobuf source as a submodule
 #[allow(clippy::all)]
 #[rustfmt::skip]
+#[cfg(not(feature = "json"))]
 pub mod datafusion;
+
+#[allow(clippy::all)]
+#[rustfmt::skip]
+#[cfg(feature = "json")]
+pub mod datafusion_json;
diff --git a/datafusion/proto/src/lib.rs b/datafusion/proto/src/lib.rs
@@ -24,7 +24,11 @@ pub mod from_proto;
 pub mod generated;
 pub mod logical_plan;
 pub mod to_proto;
-use generated::datafusion as protobuf;
+
+#[cfg(not(feature = "json"))]
+pub use generated::datafusion as protobuf;
+#[cfg(feature = "json")]
+pub use generated::datafusion_json as protobuf;
 
 #[cfg(doctest)]
 doc_comment::doctest!("../README.md", readme_example_test);