Skip to content

Commit

Permalink
Return error message during planning when inserting into a MemTable w…
Browse files Browse the repository at this point in the history
…ith zero partitions. (#14011)
  • Loading branch information
tobixdev authored Jan 6, 2025
1 parent 3f4297f commit 487b952
Showing 1 changed file with 31 additions and 0 deletions.
31 changes: 31 additions & 0 deletions datafusion/core/src/datasource/memory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,10 @@ impl TableProvider for MemTable {
input: Arc<dyn ExecutionPlan>,
insert_op: InsertOp,
) -> Result<Arc<dyn ExecutionPlan>> {
if self.batches.is_empty() {
return plan_err!("Cannot insert into MemTable with zero partitions.");
}

// If we are inserting into the table, any sort order may be messed up so reset it here
*self.sort_order.lock() = vec![];

Expand Down Expand Up @@ -333,7 +337,11 @@ impl DisplayAs for MemSink {
}

impl MemSink {
/// Creates a new [`MemSink`].
///
/// The caller is responsible for ensuring that there is at least one partition to insert into.
fn new(batches: Vec<PartitionData>) -> Self {
assert!(!batches.is_empty());
Self { batches }
}
}
Expand Down Expand Up @@ -779,4 +787,27 @@ mod tests {
assert_eq!(resulting_data_in_table[0].len(), 2);
Ok(())
}

// Test inserting a batch into a MemTable without any partitions
#[tokio::test]
async fn test_insert_into_zero_partition() -> Result<()> {
// Create a new schema with one field called "a" of type Int32
let schema = Arc::new(Schema::new(vec![Field::new("a", DataType::Int32, false)]));

// Create a new batch of data to insert into the table
let batch = RecordBatch::try_new(
schema.clone(),
vec![Arc::new(Int32Array::from(vec![1, 2, 3]))],
)?;
// Run the experiment and expect an error
let experiment_result = experiment(schema, vec![], vec![vec![batch.clone()]])
.await
.unwrap_err();
// Ensure that there is a descriptive error message
assert_eq!(
"Error during planning: Cannot insert into MemTable with zero partitions.",
experiment_result.strip_backtrace()
);
Ok(())
}
}

0 comments on commit 487b952

Please sign in to comment.