Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add custom operator #868

Merged
merged 3 commits into from
May 17, 2023
Merged

feat: Add custom operator #868

merged 3 commits into from
May 17, 2023

Conversation

max-sixty
Copy link
Contributor

From #863

  • It doesn't parse anything — I'm not sure how to parse SELECT 'a' REGEXP '^[a-d]'; with REGEXP as the operator... (but fine for my narrow purpose)
  • If we need tests, where would I add them?

From apache#863

- It doesn't parse anything — I'm not sure how to parse ` SELECT 'a' REGEXP '^[a-d]';` with `REGEXP` as the operator... (but fine for my narrow purpose)
- If we need tests, where would I add them?
@ankrgyl
Copy link
Contributor

ankrgyl commented May 8, 2023

Apologies if I'm missing some context, but what is the purpose of this new operator? Is it so you can build up a tree manually with a custom string at a certain position?

@max-sixty
Copy link
Contributor Author

Yes, we'd like to write:

 SELECT 'a' REGEXP '^[a-d]';

...which is how MySQL & Sqllite do regex...

@ankrgyl
Copy link
Contributor

ankrgyl commented May 9, 2023

I'll add some comments on the task!

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me -- thank you @max-sixty
I took the liberty of adding a docstring to try and make the use case clearer (and avoid it being deleted by accident in the future

@coveralls
Copy link

coveralls commented May 17, 2023

Pull Request Test Coverage Report for Build 5005987524

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 86.16%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/operator.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 5005960670: -0.005%
Covered Lines: 14344
Relevant Lines: 16648

💛 - Coveralls

@alamb alamb merged commit feaa13c into apache:main May 17, 2023
@max-sixty max-sixty deleted the custom-operator branch May 17, 2023 17:28
@max-sixty
Copy link
Contributor Author

Thanks @alamb !

@alamb
Copy link
Contributor

alamb commented May 19, 2023

BTW I expect to release the next version of sqlparser to crates.io today, which will include this fix

max-sixty added a commit to max-sixty/prql that referenced this pull request May 23, 2023
Uses the new custom operators feature from `sqlparser-rs` apache/datafusion-sqlparser-rs#868
serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
* Support identifiers beginning with digits in MySQL (apache#856)

* support COPY INTO in snowflake (apache#841)

Signed-off-by: Pawel Leszczynski <[email protected]>

* Add `dialect_from_str` and improve `Dialect` documentation (apache#848)

* Add `dialect_from_str` and improve `Dialect` documentation

* cleanup

* fix compilation with nostd

* Support multiple-table DELETE syntax (apache#855)

* Support `DISTINCT ON (...)` (apache#852)

* Support "DISTINCT ON (...)"

* a test

* fix the merge

* Test trailing commas (apache#859)

* test: add tests for trailing commas

* tweaks

* Add support for query source in COPY .. TO statement (apache#858)

* Add support for query source in COPY .. TO statement

* Fix compile error

* Fix logical merge conflict (apache#865)

* Fix tiny typo in custom_sql_parser.md (apache#864)

* Make Expr::Interval its own struct (apache#872)

* Make Expr::Interval its own struct

* Add test interval display

* Fix cargo fmt

* Include license file in published crate (apache#871)

* Add support for multiple expressions, order by in aggregations (apache#879)

* Add support for multiple expressions, order by in aggregations

* Fix formatting errors

* Resolve linter errors

* Add parse_multipart_identifier function to parser (apache#860)

* Add parse_multipart_identifier function to parser

* Update doc for parse_multipart_identifier

* Fix conflict

* feat: Add custom operator (apache#868)

* feat: Add custom operator

From apache#863

- It doesn't parse anything — I'm not sure how to parse ` SELECT 'a' REGEXP '^[a-d]';` with `REGEXP` as the operator... (but fine for my narrow purpose)
- If we need tests, where would I add them?

* Update src/ast/operator.rs

---------

Co-authored-by: Andrew Lamb <[email protected]>

* feat: Support MySQL's `DIV` operator (apache#876)

* feat: MySQL's DIV operator

* fix: do not use `_` prefix for used variable

---------

Co-authored-by: Andrew Lamb <[email protected]>

* truncate: table as optional keyword (apache#883)

Signed-off-by: Maciej Obuchowski <[email protected]>

* feat: add DuckDB dialect (apache#878)

* feat: add DuckDB dialect

* formatting

* fix conflict

* support // in GenericDialect

* add DucDbDialect to all_dialects

* add comment from suggestion

Co-authored-by: Andrew Lamb <[email protected]>

* fix: support // in GenericDialect

---------

Co-authored-by: Andrew Lamb <[email protected]>

* Add support for first, last aggregate function parsing (apache#882)

* Add order by parsing to functions

* Fix doc error

* minor changes

* Named window frames (apache#881)

* after over clause, named window can be parsed with window ... as after having clause

* Lint errors are fixed

* Support for multiple windows

* fix lint errors

* simplifications

* rename function

* Rewrite named window search in functional style

* Test added and some minor changes

* Minor changes on tests and namings, and semantic check is removed

---------

Co-authored-by: Mustafa Akur <[email protected]>
Co-authored-by: Mehmet Ozan Kabak <[email protected]>

* Fix merge conflict (apache#885)

* Update CHANGELOG for `0.34.0` release (apache#884)

* chore: Release sqlparser version 0.34.0

* Update criterion requirement from 0.4 to 0.5 in /sqlparser_bench (apache#890)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: Pawel Leszczynski <[email protected]>
Signed-off-by: Maciej Obuchowski <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: AviRaboah <[email protected]>
Co-authored-by: pawel.leszczynski <[email protected]>
Co-authored-by: Andrew Lamb <[email protected]>
Co-authored-by: Aljaž Mur Eržen <[email protected]>
Co-authored-by: Armin Primadi <[email protected]>
Co-authored-by: Okue <[email protected]>
Co-authored-by: Andrew Kane <[email protected]>
Co-authored-by: Mustafa Akur <[email protected]>
Co-authored-by: Jeffrey <[email protected]>
Co-authored-by: Maximilian Roos <[email protected]>
Co-authored-by: eitsupi <[email protected]>
Co-authored-by: Maciej Obuchowski <[email protected]>
Co-authored-by: Berkay Şahin <[email protected]>
Co-authored-by: Mustafa Akur <[email protected]>
Co-authored-by: Mehmet Ozan Kabak <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants