Support UPDATE ... FROM ( subquery ) in some dialects
#694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AugustoFKL
suggested changes
Oct 29, 2022
src/parser.rs
Outdated
| @@ -5075,7 +5075,9 @@ impl<'a> Parser<'a> { | |||
| let table = self.parse_table_and_joins()?; | |||
| self.expect_keyword(Keyword::SET)?; | |||
| let assignments = self.parse_comma_separated(Parser::parse_assignment)?; | |||
| let from = if self.parse_keyword(Keyword::FROM) && dialect_of!(self is PostgreSqlDialect) { | |||
| let from = if self.parse_keyword(Keyword::FROM) | |||
| && dialect_of!(self is PostgreSqlDialect | BigQueryDialect | SnowflakeDialect | RedshiftSqlDialect | MsSqlDialect) | |||
There was a problem hiding this comment.
@unvalley please add the GenericDialect as well
| fn parse_update_set_from() { | ||
| let sql = "UPDATE t1 SET name = t2.name FROM (SELECT name, id FROM t1 GROUP BY id) AS t2 WHERE t1.id = t2.id"; | ||
| let dialects = TestedDialects { | ||
| dialects: vec
|
@AugustoFKL Thank you for reviewing. I added GenericDialect to parse and test target. |
AugustoFKL
suggested changes
Oct 30, 2022
| Box::new(PostgreSqlDialect {}), | ||
| Box::new(BigQueryDialect {}), | ||
| Box::new(RedshiftSqlDialect {}), | ||
| Box::new(MsSqlDialect {}), |
AugustoFKL
approved these changes
Oct 30, 2022
Pull Request Test Coverage Report for Build 3448066476
💛 - Coveralls |
|
I took the liberty of merging this PR to the master branch and resolving the conflicts (from #666). Sadly it did not quite make the 0.27 release |
alamb
approved these changes
Nov 11, 2022
ggaughan
added a commit
to ggaughan/sqlparser-rs
that referenced
this pull request
Jan 29, 2024
"UPDATE-FROM is supported beginning in SQLite version 3.33.0 (2020-08-14)." from https://www.sqlite.org/lang_update.html
alamb
pushed a commit
that referenced
this pull request
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #534
Apply
UPDATE .. FROM (subquery)for