Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ReferentialAction enum in DROP statements #1648

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

stepancheg
Copy link
Contributor

There's <drop behavior> definition in the grammar, so corresponding enum seems appropriate:

pub enum DropBehavior {
    Restrict,
    Cascade,
}

vs

pub enum ReferentialAction {
    Restrict,
    Cascade,
    SetNull,
    NoAction,
    SetDefault,
}

Context: ALTER TABLE DROP COLUMN sqlparser does not support RESTRICT. I wanted to add it, but adding ReferentialAction there too might be misleading, so here I introduce an enum.

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stepancheg! This improvement sounds reasonable to me!
cc @alamb

@iffyio iffyio changed the title enum DropBehavior Replace ReferentialAction enum in DROP statements Jan 8, 2025
@iffyio iffyio merged commit 397bceb into apache:main Jan 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants