-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support trailing commas in FROM
clause
#1645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @barsela1! The changes look reasonable to me overall, left some comments
Co-authored-by: Ifeanyi Ubah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@barsela1 could you take a look to resolve the conflicts on the branch? |
I also restarted the checks |
support trailing commas in FROM clause.
--get_reserved_keyword_after_from function that returns ALLOWED_KEYWORD_AFTER_FROM as default. each dialect can customize the list if needed.
-- supports_from_trailing_commas function that returns false as default but for each dialect that supports trailing commas in the FROM clause can customize the return value to true (e.g., Snowflake).
-at is_parse_comma_separated_end_with_trailing_commas: keywords::RESERVED_FOR_COLUMN_ALIAS.contains(&kw.keyword) replaced by reserved_keywords so that the reserved_keywords can be determined by the current parsing state.
tests:
-added new tests.
-all tests passed.