Parse Snowflake USE ROLE and USE SECONDARY ROLES #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Dec 5, 2024
iffyio
reviewed
Dec 5, 2024
There was a problem hiding this comment.
Thanks @yoavcloud! Just one minor comment on the std assert_eq import
tests/sqlparser_snowflake.rs
Outdated
Comment on lines
2712
to
2719
| std::assert_eq!( | ||
| snowflake().verified_stmt(&format!("USE ROLE {0}my_role{0}", quote)), | ||
| Statement::Use(Use::Role(ObjectName(vec![Ident::with_quote( | ||
| quote, | ||
| "my_role".to_string(), | ||
| )]))) | ||
| ); | ||
| std::assert_eq!( |
There was a problem hiding this comment.
Suggested change
| std::assert_eq!( | |
| snowflake().verified_stmt(&format!("USE ROLE {0}my_role{0}", quote)), | |
| Statement::Use(Use::Role(ObjectName(vec![Ident::with_quote( | |
| quote, | |
| "my_role".to_string(), | |
| )]))) | |
| ); | |
| std::assert_eq!( | |
| assert_eq!( | |
| snowflake().verified_stmt(&format!("USE ROLE {0}my_role{0}", quote)), | |
| Statement::Use(Use::Role(ObjectName(vec![Ident::with_quote( | |
| quote, | |
| "my_role".to_string(), | |
| )]))) | |
| ); | |
| assert_eq!( |
if these were autoimported?
There was a problem hiding this comment.
Fixed across the board
yoavcloud
force-pushed
the
sf_use_role
branch
from
dfa1183 to
61199fe
Compare
hansott
added a commit
to AikidoSec/datafusion-sqlparser-rs
that referenced
this pull request
Dec 26, 2024
into update * tag 'v0.53.0' of https://github.com/apache/datafusion-sqlparser-rs: (66 commits) Run cargo fmt in derive crate Add Apache license header to spans.rs Update version to 0.53.0 and add release notes (apache#1592) Add support for ODBC functions (apache#1585) Parse `INSERT` with subquery when lacking column names (apache#1586) Support INSERT OVERWRITE INTO syntax (apache#1584) Snowflake ALTER TABLE clustering options (apache#1579) Parse Snowflake USE ROLE and USE SECONDARY ROLES (apache#1578) Add support of the ENUM8|ENUM16 for ClickHouse dialect (apache#1574) Fix displaying WORK or TRANSACTION after BEGIN (apache#1565) Support parsing optional nulls handling for unique constraint (apache#1567) Support BIT column types (apache#1577) Encapsulate CreateFunction (apache#1573) Support Databricks struct literal (apache#1542) Update comments / docs for `Spanned` (apache#1549) Support snowflake double dot notation for object name (apache#1540) `json_object('k' VALUE 'v')` in postgres (apache#1547) Increase version of sqlparser_derive from 0.2.2 to 0.3.0 (apache#1571) Support MySQL size variants for BLOB and TEXT columns (apache#1564) Rename `TokenWithLocation` to `TokenWithSpan`, in backwards compatible way (apache#1562) ...
hansott
added a commit
to AikidoSec/datafusion-sqlparser-rs
that referenced
this pull request
Dec 26, 2024
… into sqlitedollar * 'update' of github.com:AikidoSec/datafusion-sqlparser-rs: (66 commits) Run cargo fmt in derive crate Add Apache license header to spans.rs Update version to 0.53.0 and add release notes (apache#1592) Add support for ODBC functions (apache#1585) Parse `INSERT` with subquery when lacking column names (apache#1586) Support INSERT OVERWRITE INTO syntax (apache#1584) Snowflake ALTER TABLE clustering options (apache#1579) Parse Snowflake USE ROLE and USE SECONDARY ROLES (apache#1578) Add support of the ENUM8|ENUM16 for ClickHouse dialect (apache#1574) Fix displaying WORK or TRANSACTION after BEGIN (apache#1565) Support parsing optional nulls handling for unique constraint (apache#1567) Support BIT column types (apache#1577) Encapsulate CreateFunction (apache#1573) Support Databricks struct literal (apache#1542) Update comments / docs for `Spanned` (apache#1549) Support snowflake double dot notation for object name (apache#1540) `json_object('k' VALUE 'v')` in postgres (apache#1547) Increase version of sqlparser_derive from 0.2.2 to 0.3.0 (apache#1571) Support MySQL size variants for BLOB and TEXT columns (apache#1564) Rename `TokenWithLocation` to `TokenWithSpan`, in backwards compatible way (apache#1562) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Snowflake
USE ROLE <role>andUSE SECONDARY ROLESas described here: https://docs.snowflake.com/en/sql-reference/sql/use-secondary-roles