Fix error in benchmark queries #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Nov 26, 2024
| @@ -23,24 +23,24 @@ fn basic_queries(c: &mut Criterion) { | |||
| let mut group = c.benchmark_group("sqlparser-rs parsing benchmark"); | |||
| let dialect = GenericDialect {}; | |||
|
|
|||
| let string = "SELECT * FROM table WHERE 1 = 1"; | |||
| let string = "SELECT * FROM my_table WHERE 1 = 1"; | |||
There was a problem hiding this comment.
"table" is a keyword so you can't use it as a table name without putting it in quotes
| group.bench_function("sqlparser::select", |b| { | ||
| b.iter(|| Parser::parse_sql(&dialect, string)); | ||
| b.iter(|| Parser::parse_sql(&dialect, string).unwrap()); |
There was a problem hiding this comment.
The unwrap now actually checks the error
|
Thank you for the review @iffyio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the benchmarks are measuring how fast we can generate error messages