Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding Display implementation to DELETE and INSERT #1427

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

seve-martinez
Copy link
Contributor

Closes #1420 .

@seve-martinez seve-martinez changed the title adding display to DELETE and INSERT feat: adding Display implementation to DELETE and INSERT Sep 13, 2024
@seve-martinez seve-martinez force-pushed the smartinez/add_display_to_DML branch from bb61497 to 2bdbd17 Compare September 13, 2024 21:46
@coveralls
Copy link

coveralls commented Sep 13, 2024

Pull Request Test Coverage Report for Build 10976627530

Details

  • 55 of 61 (90.16%) changed or added relevant lines in 2 files are covered.
  • 11 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 89.34%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/dml.rs 54 60 90.0%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 11 82.09%
Totals Coverage Status
Change from base Build 10971828683: -0.01%
Covered Lines: 29668
Relevant Lines: 33208

💛 - Coveralls

src/ast/dml.rs Show resolved Hide resolved
@seve-martinez seve-martinez force-pushed the smartinez/add_display_to_DML branch from c80931a to add9bb9 Compare September 22, 2024 00:01
@iffyio
Copy link
Contributor

iffyio commented Sep 23, 2024

@seve-martinez could you take a look at the ci faiiure? I think you might need to fetch the latest changes from main for the codestyle step

@seve-martinez seve-martinez force-pushed the smartinez/add_display_to_DML branch from 5ef61d4 to 3ceb856 Compare October 7, 2024 15:14
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iffyio and @seve-martinez

@alamb
Copy link
Contributor

alamb commented Oct 20, 2024

Looks like we have a CI failure on this PR -- I think it will be straightforward

@coveralls
Copy link

coveralls commented Oct 20, 2024

Pull Request Test Coverage Report for Build 11446580065

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 59 of 71 (83.1%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 89.376%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/dml.rs 57 63 90.48%
src/ast/mod.rs 2 8 25.0%
Totals Coverage Status
Change from base Build 11429400839: -0.01%
Covered Lines: 30445
Relevant Lines: 34064

💛 - Coveralls

@alamb
Copy link
Contributor

alamb commented Oct 21, 2024

As I am preparing a release today I pushed a commit to get this CI passing

@alamb alamb merged commit 38f1e57 into apache:main Oct 21, 2024
10 checks passed
@alamb
Copy link
Contributor

alamb commented Oct 21, 2024

Thanks again @seve-martinez and @iffyio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Display implementation for other DML operations
4 participants