Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support subquery expression in SET expressions #1343

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Support subquery expression in SET expressions #1343

merged 1 commit into from
Jul 20, 2024

Conversation

iffyio
Copy link
Contributor

@iffyio iffyio commented Jul 16, 2024

BigQuery allows subqueries in a SET assignment expression

For example:

DECLARE myvar ARRAY<INT64>;
SET (myvar) = (SELECT AS STRUCT ARRAY_AGG(DISTINCT age) FROM mytable);

This adds support for the syntax.

@iffyio
Support subquery expression in SET expressions
6790144 
BigQuery allows subqueries in a SET assignment expression

For example:

```sql
DECLARE myvar ARRAY<INT64>;
SET (myvar) = (SELECT AS STRUCT ARRAY_AGG(DISTINCT age) FROM mytable);
```

This adds support for the syntax.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9958727103

Details

  • 27 of 28 (96.43%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 89.199%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 18 19 94.74%
Totals Coverage Status
Change from base Build 9944212602: 0.005%
Covered Lines: 26874
Relevant Lines: 30128
💛 - Coveralls

git-hulk
git-hulk approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alamb
alamb approved these changes Jul 20, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @iffyio and @git-hulk for the review

@alamb alamb merged commit 028ada8 into apache:main Jul 20, 2024
10 checks passed
@iffyio iffyio deleted the set-sub-query-expr branch July 21, 2024 18:19
@Jesse-Bakker Jesse-Bakker mentioned this pull request Jul 29, 2024
Closed
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Nov 19, 2024
@iffyio @ayman-sigma
Support subquery expression in SET expressions (apache#1343)
fbe910e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iffyio @coveralls @alamb @git-hulk