Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of table function WITH ORDINALITY modifier for Postgre Parser #1337

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Jul 9, 2024

This closes #1336

@git-hulk
Copy link
Member Author

git-hulk commented Jul 9, 2024

@lovasoa Can help to review when you get time, thank you!

@coveralls
Copy link

coveralls commented Jul 9, 2024

Pull Request Test Coverage Report for Build 9858237496

Details

  • 57 of 64 (89.06%) changed or added relevant lines in 9 files are covered.
  • 46 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.002%) to 89.189%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/query.rs 7 8 87.5%
tests/sqlparser_common.rs 34 40 85.0%
Files with Coverage Reduction New Missed Lines %
tests/sqlparser_mssql.rs 1 92.92%
tests/sqlparser_databricks.rs 1 85.84%
tests/sqlparser_common.rs 2 89.65%
src/ast/query.rs 3 85.63%
tests/sqlparser_bigquery.rs 6 90.18%
src/parser/mod.rs 6 93.29%
tests/sqlparser_postgres.rs 27 87.98%
Totals Coverage Status
Change from base Build 9857516073: 0.002%
Covered Lines: 26803
Relevant Lines: 30052

💛 - Coveralls

Copy link
Contributor

@lovasoa lovasoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WITH ORDINALITY is also supported after UNNEST, which I think needs special handling in sqlparser

src/parser/mod.rs Outdated Show resolved Hide resolved
tests/sqlparser_postgres.rs Outdated Show resolved Hide resolved
@git-hulk git-hulk requested a review from lovasoa July 9, 2024 12:50
@git-hulk
Copy link
Member Author

git-hulk commented Jul 9, 2024

WITH ORDINALITY is also supported after UNNEST, which I think needs special handling in sqlparser

Yes, good catch. Done in commit: a3cb42a.

@git-hulk git-hulk force-pushed the feature/support-pg-with-ordinality branch from a3cb42a to b8a08a7 Compare July 9, 2024 13:44
Copy link
Contributor

@lovasoa lovasoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me!

👍

@git-hulk
Copy link
Member Author

git-hulk commented Jul 9, 2024

cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @git-hulk and @lovasoa

@alamb alamb merged commit 9108bff into apache:main Jul 9, 2024
10 checks passed
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for WITH ORDINALITY
4 participants