Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stale PR github workflow #1331

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Add stale PR github workflow #1331

merged 1 commit into from
Jul 8, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 8, 2024

Rationale

There are some long standing stale PRs in this repo: https://github.com/sqlparser-rs/sqlparser-rs/pulls?q=is%3Apr+is%3Aopen+

It would be nice to close them automatically after some time so it is clear what PRs need attention and which don't

Changes

We have a job setup in DataFusion to do this:

  1. A note is added after 60 days of no activity
  2. 7 days after that with no activity they are closed

Copied from https://github.com/apache/datafusion/blob/main/.github/workflows/stale.yml

@alamb
Copy link
Contributor Author

alamb commented Jul 8, 2024

FYI @jmhain @iffyio and @lovasoa

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9837914608

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.161%

Totals Coverage Status
Change from base Build 9827086961: 0.0%
Covered Lines: 26571
Relevant Lines: 29801

💛 - Coveralls

Copy link
Contributor

@jmhain jmhain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

@alamb
Copy link
Contributor Author

alamb commented Jul 8, 2024

Let's give it a try and see how it works

@alamb alamb merged commit bbee052 into apache:main Jul 8, 2024
10 checks passed
@alamb alamb deleted the alamb/stale_prs2 branch July 9, 2024 11:47
@alamb
Copy link
Contributor Author

alamb commented Jul 9, 2024

It seems to be working as expected. Here is an example message it posted last night: #1000 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants