Support for DuckDB Union datatype #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9651403373Details
💛 - Coveralls |
gstvg
commented
Jun 24, 2024
src/parser/mod.rs
Outdated
|
|
||
| self.expect_token(&Token::LParen)?; | ||
|
|
||
| let fields = self.parse_comma_separated0(|p| { |
There was a problem hiding this comment.
Zero field unions are invalid on DuckDB and don't even parse. Should we error here using parse_comma_separated or let downstream users handle it?
https://shell.duckdb.org/#queries=v0,create-table-tbl1-(u-union()-)~
There was a problem hiding this comment.
I think it is fine to return error here.
Pull Request Test Coverage Report for Build 9664186307Details
💛 - Coveralls |
iffyio
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g.
CREATE TABLE tbl1 (u UNION(num INTEGER, str VARCHAR));https://duckdb.org/docs/sql/data_types/union.html