Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable trailing commas in DCL #1318

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Re-enable trailing commas in DCL #1318

merged 5 commits into from
Jul 8, 2024

Conversation

MohamedAbdeen21
Copy link
Contributor

This PR should close #1211 and is a follow-up to #1212 which ignores trailing commas option when parsing DCLs.

Tests included.

cc @lovasoa

@coveralls
Copy link

coveralls commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9555826294

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 88.98%
Files with Coverage Reduction New Missed Lines %
src/parser/mod.rs 1 93.22%
Totals Coverage Status
Change from base Build 9552658771: 0.01%
Covered Lines: 26145
Relevant Lines: 29383
💛 - Coveralls

MohamedAbdeen21
MohamedAbdeen21 commented Jun 17, 2024
View reviewed changes
src/parser/mod.rs Outdated Show resolved Hide resolved
lovasoa
lovasoa suggested changes Jun 17, 2024
View reviewed changes
src/parser/mod.rs Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9555896144

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 88.98%
Files with Coverage Reduction New Missed Lines %
src/parser/mod.rs 1 93.22%
Totals Coverage Status
Change from base Build 9552658771: 0.01%
Covered Lines: 26145
Relevant Lines: 29383
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9555963037

Details

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 88.98%
Files with Coverage Reduction New Missed Lines %
src/parser/mod.rs 1 93.22%
Totals Coverage Status
Change from base Build 9552658771: 0.01%
Covered Lines: 26145
Relevant Lines: 29383
💛 - Coveralls

@MohamedAbdeen21 MohamedAbdeen21 requested a review from lovasoa June 25, 2024 10:29
@alamb
Copy link
Contributor

alamb commented Jul 8, 2024

Thanks @lovasoa and @MohamedAbdeen21 -- I am sorry I didn't see this PR earlier.

alamb
alamb approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- thank you

@alamb alamb merged commit f77192d into apache:main Jul 8, 2024
10 checks passed
@alamb alamb mentioned this pull request Jul 8, 2024
Merged
@MohamedAbdeen21 MohamedAbdeen21 deleted the dcl_trailing_commas branch July 8, 2024 17:21
@Jesse-Bakker Jesse-Bakker mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovasoa lovasoa lovasoa approved these changes

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on some GRANTs when trailing commas are enabled
4 participants
@MohamedAbdeen21 @coveralls @alamb @lovasoa