Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few typos in comment lines #1316

Merged
merged 2 commits into from
Jun 30, 2024
Merged

Fix a few typos in comment lines #1316

merged 2 commits into from
Jun 30, 2024

Conversation

git-hulk
Copy link
Member

No description provided.

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the cleanup @git-hulk! cc @alamb

@coveralls
Copy link

coveralls commented Jun 30, 2024

Pull Request Test Coverage Report for Build 9548183696

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 164 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.1%) to 89.003%

Files with Coverage Reduction New Missed Lines %
src/parser/alter.rs 2 66.67%
tests/sqlparser_common.rs 4 89.57%
src/dialect/mod.rs 5 72.08%
src/lib.rs 153 13.01%
Totals Coverage Status
Change from base Build 9439708625: 0.1%
Covered Lines: 26134
Relevant Lines: 29363

💛 - Coveralls

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @git-hulk -- I merged up from main to resolve a conflict

Thank you for the reviews @lovasoa and @iffyio -- Sorry for not seeing this PR earlier. Please mention me explicitly if you think a PR is ready for merge and I'll check it out

@alamb alamb merged commit 0b1a413 into apache:main Jun 30, 2024
10 checks passed
@coveralls
Copy link

coveralls commented Jun 30, 2024

Pull Request Test Coverage Report for Build 9731498489

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.079%

Totals Coverage Status
Change from base Build 9731484169: 0.0%
Covered Lines: 26380
Relevant Lines: 29614

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants