Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in sqlparser-derive README #1310

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

leoyvens
Copy link
Contributor

This is just from reading it, but I think that bit is wrong.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @leoyvens and @lovasoa

@alamb alamb changed the title minor fix to derive README Fix typo in sqlparser-derive README Jul 8, 2024
@alamb alamb merged commit 66b4ec8 into apache:main Jul 8, 2024
10 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9499265144

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 164 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.1%) to 89.003%

Files with Coverage Reduction New Missed Lines %
src/parser/alter.rs 2 66.67%
tests/sqlparser_common.rs 4 89.57%
src/dialect/mod.rs 5 72.08%
src/lib.rs 153 13.01%
Totals Coverage Status
Change from base Build 9439708625: 0.1%
Covered Lines: 26134
Relevant Lines: 29363

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants