-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support use of BY NAME
quantifier across all set ops
#1309
Support use of BY NAME
quantifier across all set ops
#1309
Conversation
Pull Request Test Coverage Report for Build 9478220409Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9481344190Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9481781619Details
💛 - Coveralls |
72b35f2
to
7ca607f
Compare
Pull Request Test Coverage Report for Build 9482850329Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9482845468Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, many thanks for the typo cleanups! cc @alamb
Co-authored-by: Joey Hain <[email protected]>
Pull Request Test Coverage Report for Build 9487455051Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jmhain and @alexander-beedie
@@ -210,6 +209,7 @@ licensed as above, without any additional terms or conditions. | |||
[Ballista]: https://github.com/apache/arrow-ballista | |||
[GlueSQL]: https://github.com/gluesql/gluesql | |||
[Opteryx]: https://github.com/mabel-dev/opteryx | |||
[Polars]: https://pola.rs/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
It turns out that that use of the "BY NAME" quantifier was being artificially constrained to
UNION
set ops - however, there are dialects that allow it for all set ops (which actually makes a lot of sense).I'm about to implement this additional "BY NAME" set op support for the Polars SQL interface (which will need this patch), but the expanded usage is already found in the wild; see Microsoft's U-SQL dialect (as used in Azure Data Lake Analytics) for an example:
EXCEPT [BY NAME]
: https://learn.microsoft.com/en-gb/archive/usql/statements-and-expressions/set-rowset/except-expressionINTERSECT [BY NAME]
: https://learn.microsoft.com/en-gb/archive/usql/statements-and-expressions/set-rowset/intersect-expressionAlso:
polars
also uses the parser 👍