-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClickHouse: support of create table query with primary key and parametrised table engine #1289
ClickHouse: support of create table query with primary key and parametrised table engine #1289
Conversation
Pull Request Test Coverage Report for Build 9369081951Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
7c836ab
to
12faee5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc @alamb
Thanks @iffyio for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
77f781b
to
79327da
Compare
Thanks @alamb for review and that you letting me know about conflicts. I rebased my PR with |
Thanks @7phs ! |
This PR implements extended support of query
CREATE TABLE
in ClickHouse that contains the following additional parameters and differentiation:ORDER BY
in aCREATE TABLE
query;ORDER BY
can include expression and not only indication.