Add support for view comments for Snowflake #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snowflake supports adding a comment when creating a view, see https://docs.snowflake.com/en/sql-reference/sql/create-view#syntax.
Pull Request Test Coverage Report for Build 9265999109Details
💛 - Coveralls |
iffyio
reviewed
May 26, 2024
- Support `GenericDialect` as well - Inline keyword match - Use `expect_token` instead of `consume_token` for the equal sign - Fix faulty expect text - Move test to `sqlparser_snowflake.rs` - Add negative test for missing equal sign
Co-authored-by: Joey Hain <[email protected]>
iffyio
approved these changes
May 28, 2024
alamb
approved these changes
May 30, 2024
There was a problem hiding this comment.
Thank you for the contributon @bombsimon and thank you for the reviews @iffyio and @jmhain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowflake supports adding a comment when creating a view, see https://docs.snowflake.com/en/sql-reference/sql/create-view#syntax.