Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support: Databricks and generic: fix for values as table name #1278

Merged
merged 1 commit into from
May 21, 2024

Conversation

jmhain
Copy link
Contributor

@jmhain jmhain commented May 19, 2024

In the previous release, we added support for VALUES tables in a FROM clause without a containing subquery, as supported by Snowflake and Databricks. However, this caused a regression in DataFusion which considers values a valid table name. I did some testing and Databricks permits this as well (Snowflake does not).

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9149778305

Details

  • 38 of 43 (88.37%) changed or added relevant lines in 3 files are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 89.462%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/query.rs 3 4 75.0%
tests/sqlparser_databricks.rs 32 36 88.89%
Files with Coverage Reduction New Missed Lines %
tests/sqlparser_databricks.rs 10 85.84%
Totals Coverage Status
Change from base Build 9117210757: -0.03%
Covered Lines: 24926
Relevant Lines: 27862

💛 - Coveralls

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jmhain

@alamb alamb changed the title Databricks and generic: fix for values as table name Support: Databricks and generic: fix for values as table name May 21, 2024
@alamb alamb merged commit 9d15f7e into apache:main May 21, 2024
10 checks passed
@jmhain jmhain deleted the values-fix branch May 21, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants