Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake: support IGNORE/RESPECT NULLS inside function argument list #1263

Merged
merged 3 commits into from
May 16, 2024

Conversation

jmhain
Copy link
Contributor

@jmhain jmhain commented May 7, 2024

Just a tiny fix for a parsing failure I hit.

@coveralls
Copy link

coveralls commented May 7, 2024

Pull Request Test Coverage Report for Build 9090118483

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 89.492%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/dialect/snowflake.rs 1 2 50.0%
Totals Coverage Status
Change from base Build 9060810029: -0.003%
Covered Lines: 24878
Relevant Lines: 27799

💛 - Coveralls

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a test for this too so it doesn't get broken accidentally in a future release?

Thanks for the review @iffyio

@jmhain
Copy link
Contributor Author

jmhain commented May 11, 2024

@alamb parse_window_function_null_treatment_arg currently covers this since it uses all_dialects_where(|d| d.supports_window_function_null_treatment_arg()). Or did you have some other idea for a test in mind?

@alamb
Copy link
Contributor

alamb commented May 13, 2024

@alamb parse_window_function_null_treatment_arg currently covers this since it uses all_dialects_where(|d| d.supports_window_function_null_treatment_arg()). Or did you have some other idea for a test in mind?

What I was thinking was "if someone accidentally broke this feature in the future (by reverting this code, for example), there would be no test failure to let us know of the regression"

If you are fine with that risk I think we can merge this PR once its conflicts are resolved, given how small it is.

@jmhain
Copy link
Contributor Author

jmhain commented May 15, 2024

@alamb Gotcha, added a Snowflake specific test and resolved the conflicts

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmhain

@alamb alamb merged commit 5418446 into apache:main May 16, 2024
10 checks passed
@jmhain jmhain deleted the null_treatment_sf branch May 16, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants